Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameterize message origin in Tests #36

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Parameterize message origin in Tests #36

merged 1 commit into from
Nov 24, 2023

Conversation

alistair-singh
Copy link

@alistair-singh alistair-singh commented Nov 23, 2023 •
edited
Loading

Resolves: SNO-763
Snowbrigde Companion: Snowfork/snowbridge#1018

@alistair-singh alistair-singh mentioned this pull request Nov 23, 2023
Merged
@yrong
Copy link

yrong commented Nov 23, 2023

Awesome! So will this PR companion with the previous #22 and resubmit to polkadot-sdk?

@alistair-singh
Copy link
Author

Awesome! So will this PR companion with the previous #22 and resubmit to polkadot-sdk?

I think we will close #22 and revert to our older implementation where we have our own custom AggregateMessageOrigin for BridgeHub. Then submit one big PR to polkadot-sdk with all our changes.

@alistair-singh alistair-singh merged commit 3c0018a into snowbridge Nov 24, 2023
4 of 8 checks passed
@alistair-singh alistair-singh deleted the alistair/parameterize-message-origin branch November 24, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alistair-singh @yrong