This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
Custom digest item #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-singh
approved these changes
Dec 14, 2023
yrong
reviewed
Dec 15, 2023
Comment on lines
29
to
32
| impl Into<DigestItem> for CustomDigestItem { | ||
| fn into(self) -> DigestItem { | ||
| match self { | ||
| // For snowbridge, we sidestep SCALE-encoding of `CustomDigestItem`, and insert the | ||
| // merkle root directly into the DigestItem::Other payload. This reduces complexity | ||
| // and gas costs on the Ethereum side. | ||
| // | ||
| // Other light clients can discriminate between custom digest items by checking the | ||
| // length of the encoded payload. If the length is greater than 32, then its a digest | ||
| // item inserted by some application other than Snowbridge. | ||
| CustomDigestItem::Snowbridge(merkle_root) => | ||
| DigestItem::Other(merkle_root.to_fixed_bytes().into()), | ||
| } | ||
| } |
There was a problem hiding this comment.
I prefer not to sidestep here instead include the Enum prefix(0) as discrimination.
Some companioned change required:
- solidity
https://github.com/Snowfork/snowbridge/blob/c03175b813ee97373843de4f70ea10df1977beb7/contracts/src/Verification.sol#L136
to something like
if (item.kind == DIGEST_ITEM_OTHER && item.data.length == 33 && commitment == bytes32(item.data[1:]))
and IMO it may not increase gas costs that much. - parachain relayer
https://github.com/Snowfork/snowbridge/blob/c03175b813ee97373843de4f70ea10df1977beb7/relayer/relays/parachain/digest_item.go#L11
Similar changes required.
yrong
force-pushed
the
custom-digest-item
branch
from
f10daf2
to
13395c1
Compare
|
This is obsolete right, @yrong, can we close it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion for Snowfork/snowbridge#1053