Add Ethereum router #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
commented
Nov 2, 2023
|
|
||
| pub type ToEthereumXcmRouterInstance = pallet_assets::Instance3; | ||
| impl pallet_xcm_bridge_hub_router::Config<ToEthereumXcmRouterInstance> for Runtime { | ||
| type WeightInfo = weights::pallet_xcm_bridge_hub_router_to_rococo::WeightInfo<Runtime>; // TODO do for ethereum |
There was a problem hiding this comment.
Not sure if we should add our own weights file here - there doesn't seem to be a difference in the xcm router pallet weights (i.e. Rococo and Wococo xcm router pallet weights are generated with the same command)
There was a problem hiding this comment.
yeah just the copy the file and rename it appropriately, I'd say.
|
Tested:
Routing from |
vgeddes
approved these changes
Nov 2, 2023
alistair-singh
approved these changes
Nov 2, 2023
claravanstaden
force-pushed
the
clara/sno-731-ethereum-router
branch
from
e3fa80f
to
820a012
Compare
claravanstaden
force-pushed
the
clara/sno-731-ethereum-router
branch
from
820a012
to
25e63c2
Compare
|
Closed in favour of #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a separate router to Ethereum, instead of reusing the existing Rococo router.
Resolves: SNO-731