This repository has been archived by the owner on Oct 22, 2024. It is now read-only.
forked from paritytech/polkadot-sdk
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claravanstaden
approved these changes
Dec 22, 2023
parameter_types! { | ||
pub const ChainForkVersions: ForkVersions = ForkVersions { | ||
genesis: Fork { | ||
version: [0, 0, 16, 32], // 0x00001020 | ||
version: [144, 0, 0, 111], // 0x90000069 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no, I missed updating the fork versions for Sepolia. 😞 Thanks for catching this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we need this fix for the launch.
yrong
commented
Dec 22, 2023
Comment on lines
+615
to
617
parameter_types! { | ||
pub const MaxExecutionHeadersToKeep: u32 = prod_or_fast!(8192 * 2, 1000); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Macro prod_or_fast
for fast-runtime feature
claravanstaden
pushed a commit
that referenced
this pull request
Dec 22, 2023
* Refactoring with fast-runtime * Fix ForkVersions for sepolia * beacon-spec-minimal * Use fast-runtime in BH
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.