Check is_bridge_upgraded at post_upgrade phase #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
reviewed
May 18, 2024
| @@ -85,6 +90,8 @@ impl OnRuntimeUpgrade for UnstuckSnowbridge { | |||
| #[cfg(feature = "try-runtime")] | |||
| fn post_upgrade(_: Vec<u8>) -> Result<(), TryRuntimeError> { | |||
| frame_support::ensure!(!is_bridge_stuck(), "Snowbridge is still stuck."); | |||
| frame_support::ensure!(is_bridge_upgraded(), "Snowbridge is not migrated."); | |||
There was a problem hiding this comment.
I think this is to create false negatives (errors) later down the line when the try-runtime tests fork BridgeHub after the relayer has imported new headers, and the check in is_bridge_upgraded fail
| @@ -47,6 +49,9 @@ impl OnRuntimeUpgrade for UnstuckSnowbridge { | |||
| if !is_bridge_stuck() { | |||
| return RocksDbWeight::get().reads(1); | |||
| } | |||
| if is_bridge_upgraded() { | |||
There was a problem hiding this comment.
This is redundant and adds confusion. The upgrade should only run if the bridge is stuck according to is_bridge_stuck.
is_bridge_stuck will return false when the last imported header is not the buggy header, indicating that the bridge is migrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.