Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cumulus package versions #809

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Use cumulus package versions #809

merged 2 commits into from
Apr 18, 2023

Conversation

alistair-singh
Copy link
Contributor

  • serde_json = "1.0.96"
  • serde = "1.0.160"
  • hex-literal = "0.4.1"

Cumulus Companion: Snowfork/cumulus#16

@alistair-singh alistair-singh mentioned this pull request Apr 18, 2023
Merged
vgeddes
vgeddes approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@doubledup
Copy link
Contributor

Should we also bump scale-info to 2.5.0 in snowbridge-router-primitives and snowbridge-inbound-queue? Looks like it's updated in the Cumulus PR

doubledup
doubledup approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@doubledup doubledup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

@alistair-singh
Copy link
Contributor Author

alistair-singh commented Apr 18, 2023 •
edited
Loading

Should we also bump scale-info to 2.5.0 in snowbridge-router-primitives and snowbridge-inbound-queue? Looks like it's updated in the Cumulus PR

Nice catch! Added this in 595342e.

@alistair-singh alistair-singh merged commit 7d7d64a into main Apr 18, 2023
@alistair-singh alistair-singh deleted the alistair/merge-from-upstream branch April 18, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgeddes vgeddes vgeddes approved these changes

@yrong yrong yrong approved these changes

@doubledup doubledup doubledup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alistair-singh @doubledup @vgeddes @yrong