Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged latest from bko-transfer-assets-via-bridge #857

Merged
merged 5 commits into from
Jun 14, 2023

Conversation

alistair-singh
Copy link
Contributor

@alistair-singh alistair-singh commented Jun 13, 2023

Resolves: SNO-512
Cumulus Companion: Snowfork/cumulus#32

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.52 ⚠️

Comparison is base (0d03d79) 74.65% compared to head (eadc891) 73.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #857      +/-   ##
==========================================
- Coverage   74.65%   73.14%   -1.52%     
==========================================
  Files          28       38      +10     
  Lines        1294     1519     +225     
  Branches        0       52      +52     
==========================================
+ Hits          966     1111     +145     
- Misses        328      388      +60     
- Partials        0       20      +20     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alistair-singh alistair-singh changed the title Alistair/merge bko Merged latest from bko-transfer-assets-via-bridge Jun 13, 2023
@alistair-singh alistair-singh marked this pull request as ready for review June 13, 2023 15:10
@alistair-singh alistair-singh requested review from doubledup, vgeddes and yrong and removed request for doubledup June 13, 2023 15:11
Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alistair-singh alistair-singh merged commit 5b7380f into main Jun 14, 2023
@alistair-singh alistair-singh deleted the alistair/merge-bko branch June 14, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants