Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable dispatch gas #962

Closed
wants to merge 2 commits into from
Closed

Configurable dispatch gas #962

wants to merge 2 commits into from

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Sep 12, 2023

Resolves: SNO-650

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.29% 🎉

Comparison is base (6b08d30) 75.23% compared to head (d02f041) 75.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
+ Coverage   75.23%   75.52%   +0.29%     
==========================================
  Files          41       41              
  Lines        1813     1806       -7     
  Branches       75       74       -1     
==========================================
  Hits         1364     1364              
+ Misses        429      423       -6     
+ Partials       20       19       -1     
Flag Coverage Δ
rust 75.74% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
contracts/src/Gateway.sol 80.00% <ø> (+3.77%) ⬆️
parachain/pallets/outbound-queue/src/lib.rs 90.54% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vgeddes
Copy link
Collaborator

vgeddes commented Sep 12, 2023

Looks good so far 👌

@vgeddes
Copy link
Collaborator

vgeddes commented Sep 12, 2023

As discussed with @musnit we may also want to include relayer reward in the message to the Gateway, to make the messaging protocol more declarative (also known as intents in DeFi terminology).

But let's confirm this first in our meeting tomorrow.

@yrong
Copy link
Contributor Author

yrong commented Sep 13, 2023

we may also want to include relayer reward in the message to the Gateway, to make the messaging protocol more declarative

Agree. The reward should not be some config per channel as we do now. It seems more like the config for each kind of the message(i.e. incentivize relayer with more reward for heavier dispatch).

@yrong
Copy link
Contributor Author

yrong commented Sep 13, 2023

Closed in favor of #940

@yrong yrong closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants