Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polkadot SDK Update V2 #972

Merged
merged 30 commits into from
Oct 30, 2023
Merged

Polkadot SDK Update V2 #972

merged 30 commits into from
Oct 30, 2023

Conversation

claravanstaden
Copy link
Contributor

@claravanstaden claravanstaden commented Oct 18, 2023 •
edited by vgeddes
Loading

Companion: Snowfork/polkadot-sdk#3

Fixes: SNO-707

@claravanstaden claravanstaden self-assigned this Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a293b68) 81.15% compared to head (fa099c8) 82.20%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   81.15%   82.20%   +1.04%     
==========================================
  Files          47       47              
  Lines        1916     2029     +113     
  Branches       71       71              
==========================================
+ Hits         1555     1668     +113     
  Misses        345      345              
  Partials       16       16
Flag Coverage Δ
rust 83.39% <100.00%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
parachain/pallets/control/src/lib.rs 99.01% <ø> (ø)
...achain/pallets/ethereum-beacon-client/src/impls.rs 56.81% <ø> (ø)
...arachain/pallets/ethereum-beacon-client/src/lib.rs 96.22% <ø> (ø)
...rachain/pallets/ethereum-beacon-client/src/mock.rs 100.00% <100.00%> (ø)
parachain/pallets/outbound-queue/src/lib.rs 100.00% <100.00%> (ø)
parachain/primitives/core/src/lib.rs 100.00% <ø> (ø)
parachain/primitives/core/src/operating_mode.rs 100.00% <ø> (ø)
parachain/primitives/core/src/outbound.rs 90.00% <ø> (ø)
parachain/primitives/router/src/outbound/mod.rs 87.96% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claravanstaden claravanstaden mentioned this pull request Oct 19, 2023
Merged
@claravanstaden
Copy link
Contributor Author

claravanstaden commented Oct 25, 2023 •
edited
Loading

Smoke tests status:

@claravanstaden claravanstaden mentioned this pull request Oct 26, 2023
Closed
@claravanstaden claravanstaden marked this pull request as ready for review October 26, 2023 21:11
vgeddes
vgeddes reviewed Oct 27, 2023
View reviewed changes
parachain/pallets/inbound-queue/src/test.rs Outdated
@@ -164,7 +157,7 @@ impl SendXcm for MockXcmSender {
match dest {
Some(MultiLocation { interior, .. }) => {
if let X1(Parachain(1001)) = interior {
return Err(XcmpSendError::NotApplicable)
return Err(XcmpSendError::NotApplicable);
Copy link
Collaborator

@vgeddes vgeddes Oct 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure your formatting settings are correct?

Both of my formatter's are not making this change:
cargo +$RUST_NIGHTLY_VERSION fmt

"rust-analyzer.rustfmt.overrideCommand": [
        "rustup",
        "run",
        "nightly-2023-05-23",
        "--",
        "rustfmt",
        "--"
    ],

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I had trouble with my local setup where the formatter didn't work in the polkadot-sdk submodule, so I turned it off temporarily but forgot to turn it back in. Fixed in Fixed in cc9b1fc..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your formatter is acting weird again, for example in in pallets/ethereum-beacon-client/src/lib.rs 😄

parachain/pallets/outbound-queue/src/lib.rs Outdated Show resolved Hide resolved
parachain/primitives/router/src/outbound/mod.rs Outdated Show resolved Hide resolved
smoketest/tests/register_token.rs Outdated Show resolved Hide resolved
@claravanstaden claravanstaden mentioned this pull request Oct 27, 2023
Closed
14 tasks
vgeddes
vgeddes approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Lets merge it in... 🚀

@claravanstaden claravanstaden merged commit 340fb14 into main Oct 30, 2023
5 checks passed
@claravanstaden claravanstaden deleted the polkadot-sdk-update-v2 branch October 30, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrong yrong yrong left review comments

@vgeddes vgeddes vgeddes approved these changes

Assignees

@claravanstaden claravanstaden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claravanstaden @vgeddes @yrong