Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve xcm integration test with CI #988

Merged
merged 30 commits into from
Nov 8, 2023
Merged

Improve xcm integration test with CI #988

merged 30 commits into from
Nov 8, 2023

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Nov 2, 2023 •
edited
Loading

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b2d4aa) 83.31% compared to head (8501967) 83.36%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #988      +/-   ##
==========================================
+ Coverage   83.31%   83.36%   +0.04%     
==========================================
  Files          51       51              
  Lines        2038     2044       +6     
  Branches       71       71              
==========================================
+ Hits         1698     1704       +6     
  Misses        325      325              
  Partials       15       15
Flag Coverage Δ
rust 83.88% <100.00%> (+0.05%) ⬆️
solidity 80.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
contracts/src/BeefyClient.sol 87.17% <ø> (ø)
parachain/pallets/inbound-queue/src/lib.rs 83.33% <100.00%> (+2.08%) ⬆️
parachain/primitives/router/src/outbound/mod.rs 90.09% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yrong yrong marked this pull request as ready for review November 6, 2023 03:30
@yrong yrong changed the base branch from main to alistair/new-reserve-transfer November 7, 2023 01:17
@yrong yrong mentioned this pull request Nov 7, 2023
Merged
2 tasks
alistair-singh
alistair-singh approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Base automatically changed from alistair/new-reserve-transfer to main November 7, 2023 14:32
vgeddes
vgeddes approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yrong yrong merged commit ecc8ae9 into main Nov 8, 2023
7 checks passed
@yrong yrong deleted the ron/xcm-integration-test branch November 8, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair-singh alistair-singh alistair-singh approved these changes

@vgeddes vgeddes vgeddes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yrong @vgeddes @alistair-singh