Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /setblock command #263

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Conversation

user622628252416
Copy link
Contributor

@user622628252416 user622628252416 commented Nov 13, 2024

Adds the the /setblock command

Description

  • add /setblock command
  • add /getblock command (to debug why "/setblock ~ ~ ~ block keep" in fact didn't keep)
  • attempt to fix block state/block id confusion
  • fix block breaking particles

Testing

  • run commands, observe results

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings cargo clippy

@user622628252416 user622628252416 marked this pull request as ready for review November 13, 2024 17:00
@user622628252416
Copy link
Contributor Author

I can remove /getblock if you don't want to keep it

@Snowiiii
Copy link
Owner

Snowiiii commented Nov 14, 2024

I can remove /getblock if you don't want to keep it

Yes, I don't really like to add non vanilla commands (/pumpkin being a exception)

@user622628252416
Copy link
Contributor Author

Done

@Snowiiii
Copy link
Owner

LGTM.
Thanks @user622628252416 ❤️

@Snowiiii Snowiiii merged commit 29d203c into Snowiiii:master Nov 14, 2024
9 checks passed
@user622628252416 user622628252416 deleted the cmd_setblock branch November 16, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants