fix: Summoner - Use username if name is missing
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,6 +46,9 @@ module.exports = function summoner(forum, config) { | |||
| debug('summoner received a mention notification!'); | |||
| return notification.getUser() | |||
| .then((user) => { | |||
| if (user.username && !user.name) { | |||
There was a problem hiding this comment.
This is a workable solution, but somewhat lacking in extensibility. what about other field combinations where information might be lacking and an alternate must be chosen.
wouldn't a replacement syntax of %name|username% to mean "name unless it is null or whitespace then use username" be a more elegant solution?
There was a problem hiding this comment.
Agreed. For now though, I think this achieves what I intended. I can always go back and implement the more extensible version later 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.