New remarks tag #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usmanatron
reviewed
Apr 8, 2020
| @@ -73,26 +73,14 @@ def get_role_paths(self): | |||
| return role_full_paths | |||
|
|
|||
| def get_playbook_paths(self): | |||
| """ Crawl Directory structure excluding role roles_path | |||
| and find all .yml files """ | |||
| """ Find all .yml files in main project directory""" | |||
| playbooks = [] | |||
|
|
|||
| # Find all .yml files in the project directory | |||
There was a problem hiding this comment.
Can we add a comment here specifically saying that we're not recursing?
usmanatron
reviewed
Apr 8, 2020
| role_info.append(roles[i]) | ||
| playbookentry["role_info"] = role_info | ||
| playbookentry["task_names"] = task_names | ||
| # Loop through Playbook tasks | ||
| if folder_content not in self.parserdata: |
There was a problem hiding this comment.
There's a lot more to this than I expected. Can we have a chat please, so I can understand what's going on?
There was a problem hiding this comment.
As discussed, please add some comments explaining what you just told me!
usmanatron
reviewed
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding: