DATAGO-85215: EMA generates its own client name based on hostname and runtime agent id #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
moodiRealist
approved these changes
Sep 20, 2024
rudraneel-chakraborty
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
rudraneel-chakraborty
deleted the
DATAGO-85215-support-rolling-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
To support rolling update, we want each EMA instance to have its own unique
clientName. Currently, the clientName is determined by only looking at the runtimeAgentId however, this becomes a problem for CEMA update scenario as, for a brief period, we can have more than 1 instance of CEMA with the same id online at the same time. Not to mention, this is also a problem if we decide to use multiple instances (replicaCount >1).This PR introduces changes so that CEMA generates its own unique client name based on the hash of the host name and appending the runtime agent id. Format is :
{runtimeAgentId}-{hash(hostname)}.We are taking the hash to ensure that we are not going over the limit
How was this change implemented?
Java
How was this change tested?
IT
Is there anything the reviewers should focus on/be aware of?