Pull a certain image tag when going to anywhere but dev #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronRushton
temporarily deployed
to
build_pr
GitHub Actions
Inactive
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
There's a scenario where we want to deploy version X.Y.Z.
We need to run different deploy scripts to go to dev, staging, then prod. This may take several days for testing in between.
In each case, we pull the image tagged with main which is whatever is in the main branch.
For dev, this is good. For staging and production, we only want to deploy the version we said we would, so the version we deploy is also the image we pull.
If we deployed to dev tagged as 1.14, then committed a new change and made the latest release 1.15, the next time we deploy to staging and prod will pull the image tagged with main which is 1.15 and then tagged with 1.14. This is confusing.
How was this change implemented?
Grab the correct image version instead of main when no deploying to development.
How was this change tested?
We're testing on the fly.
Is there anything the reviewers should focus on/be aware of?
None