feat: Replace GenericDropdownMenu with GenericMenu

The GenericDropdownMenu cannot display beyond the window it is in, and it has bugs in Unity 6000.0. Therefore, we are using GenericMenu instead. See: - https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77265 - https://discussions.unity.com/t/why-unity-6-changes-the-style-of-the-genericdropdownmenu-to-this-new-ugly-high-contrast-style/1501545/5
SolarianZ · Sep 1, 2024 · 3ed04ad · 3ed04ad
1 parent 8bf406d
commit 3ed04ad
Showing 1 changed file with 5 additions and 72 deletions.
diff --git a/Editor/Scripts/AssetItemView.cs b/Editor/Scripts/AssetItemView.cs
@@ -240,13 +240,15 @@ private void OnContextClick(Vector2 mousePosition)
             }
         }
 
+        // The GenericDropdownMenu cannot display beyond the window it is in, and it has bugs in Unity 6000.0.
+        // Therefore, we are using GenericMenu instead.
+        // MEMO Unity BUG: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77265
+        // Custom contextual menu is broken or displayed wrongly when it is created with GenericDropdownMenu UIElement
+
         private void ShowProjectAssetContextMenu(Vector2 mousePosition)
         {
             Assert.IsTrue(AssetHandle.Category == AssetCategory.ProjectAsset);
 
-            // MEMO Unity BUG: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77265
-            // Custom contextual menu is broken or displayed wrongly when it is created with GenericDropdownMenu UIElement
-#if UNITY_6000_0_OR_NEWER
             GenericMenu genericMenu = new GenericMenu();
             if (AssetHandle.Asset)
             {
@@ -264,34 +266,12 @@ private void ShowProjectAssetContextMenu(Vector2 mousePosition)
 
             genericMenu.AddItem(new GUIContent("Remove"), false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
             genericMenu.ShowAsContext();
-#else
-            GenericDropdownMenu menu = new GenericDropdownMenu();
-            if (AssetHandle.Asset)
-            {
-                menu.AddItem("Open", false, AssetHandle.OpenAsset);
-                menu.AddItem("Copy Path", false, AssetHandle.CopyPathToSystemBuffer);
-                menu.AddItem("Copy Guid", false, AssetHandle.CopyGuidToSystemBuffer);
-                menu.AddItem("Copy Type", false, AssetHandle.CopyTypeFullNameToSystemBuffer);
-                menu.AddItem("Copy Instance ID", false, AssetHandle.CopyInstanceIdToSystemBuffer);
-                menu.AddItem("Show in Folder", false, AssetHandle.ShowInFolder);
-            }
-            else
-            {
-                menu.AddItem("Copy Guid", false, AssetHandle.CopyGuidToSystemBuffer);
-            }
-
-            menu.AddItem("Remove", false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
-            menu.DropDown(new Rect(mousePosition, Vector2.zero), this, false);
-#endif
         }
 
         private void ShowSceneObjectContextMenu(Vector2 mousePosition)
         {
             Assert.IsTrue(AssetHandle.Category == AssetCategory.SceneObject);
 
-            // MEMO Unity BUG: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77265
-            // Custom contextual menu is broken or displayed wrongly when it is created with GenericDropdownMenu UIElement
-#if UNITY_6000_0_OR_NEWER
             GenericMenu genericMenu = new GenericMenu();
             if (AssetHandle.Asset)
             {
@@ -307,34 +287,13 @@ private void ShowSceneObjectContextMenu(Vector2 mousePosition)
 
             genericMenu.AddItem(new GUIContent("Remove"), false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
             genericMenu.ShowAsContext();
-#else
-            GenericDropdownMenu menu = new GenericDropdownMenu();
-            if (AssetHandle.Asset)
-            {
-                menu.AddItem("Open", false, AssetHandle.OpenAsset);
-                menu.AddItem("Copy Hierarchy Path", false, AssetHandle.CopyPathToSystemBuffer);
-                menu.AddItem("Copy Type", false, AssetHandle.CopyTypeFullNameToSystemBuffer);
-                menu.AddItem("Copy Instance ID", false, AssetHandle.CopyInstanceIdToSystemBuffer);
-            }
-            else if (AssetHandle.Scene)
-            {
-                menu.AddItem("Open in Scene", false, AssetHandle.OpenAsset);
-            }
-
-            menu.AddItem("Remove", false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
-            menu.DropDown(new Rect(mousePosition, Vector2.zero), this, false);
-#endif
         }
 
         private void ShowExternalFileContextMenu(Vector2 mousePosition)
         {
             Assert.IsTrue(AssetHandle.Category == AssetCategory.ExternalFile);
 
             string path = AssetHandle.GetAssetPath();
-
-            // MEMO Unity BUG: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77265
-            // Custom contextual menu is broken or displayed wrongly when it is created with GenericDropdownMenu UIElement
-#if UNITY_6000_0_OR_NEWER
             GenericMenu genericMenu = new GenericMenu();
             if (File.Exists(path) || Directory.Exists(path))
             {
@@ -349,43 +308,17 @@ private void ShowExternalFileContextMenu(Vector2 mousePosition)
 
             genericMenu.AddItem(new GUIContent("Remove"), false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
             genericMenu.ShowAsContext();
-#else
-            GenericDropdownMenu menu = new GenericDropdownMenu();
-            if (File.Exists(path) || Directory.Exists(path))
-            {
-                menu.AddItem("Open", false, AssetHandle.OpenAsset);
-                menu.AddItem("Copy Path", false, AssetHandle.CopyPathToSystemBuffer);
-                menu.AddItem("Show in Folder", false, AssetHandle.ShowInFolder);
-            }
-            else
-            {
-                menu.AddItem("Copy Path", false, AssetHandle.CopyPathToSystemBuffer);
-            }
-
-            menu.AddItem("Remove", false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
-            menu.DropDown(new Rect(mousePosition, Vector2.zero), this, false);
-#endif
         }
 
         private void ShowUrlContextMenu(Vector2 mousePosition)
         {
             Assert.IsTrue(AssetHandle.Category == AssetCategory.Url);
 
-            // MEMO Unity BUG: https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-77265
-            // Custom contextual menu is broken or displayed wrongly when it is created with GenericDropdownMenu UIElement
-#if UNITY_6000_0_OR_NEWER
             GenericMenu genericMenu = new GenericMenu();
             genericMenu.AddItem(new GUIContent("Open"), false, AssetHandle.OpenAsset);
             genericMenu.AddItem(new GUIContent("Copy URL"), false, AssetHandle.CopyPathToSystemBuffer);
             genericMenu.AddItem(new GUIContent("Remove"), false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
             genericMenu.ShowAsContext();
-#else
-            GenericDropdownMenu menu = new GenericDropdownMenu();
-            menu.AddItem("Open", false, AssetHandle.OpenAsset);
-            menu.AddItem("Copy URL", false, AssetHandle.CopyPathToSystemBuffer);
-            menu.AddItem("Remove", false, () => OnWantsToRemoveAssetItem?.Invoke(AssetHandle));
-            menu.DropDown(new Rect(mousePosition, Vector2.zero), this, false);
-#endif
         }