fix: metadata image correctly replaced with consecutive number so it works with cmv2 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nukec
changed the title
|
Thanks @nukec, lets put this to main please |
ck256-2000
reviewed
Jan 19, 2022
There was a problem hiding this comment.
This doesn't work as intended. it will retitle and replace image.png with a 1.png, 2.png, etc, but nftsCreatedCounter begins at 1 so you'll always be off by one. Ask me how I know :) I've submitted a fix that occurs in nft.py, last step before writing the JSON file.
|
It doesnt matter atm if is image.png or the number.png both works on metaplex upload using the latest version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New candy machine v2, requires metadata image property to be consecutive number of asset, as
image.pngdoesn't work anymore, and doesn't replace. Change was made that .json file is prepared with consecutive number for image property for instance0.pngfor0.json,1.ongfor1.json. etc