Fix quality gate (#4272)

packages/bridge/tests/tools/request.ts

@@ -28,7 +28,7 @@ export function request(server: http.Server, path: string, method: string, data:
     host: '127.0.0.1',
     path,
     method,
-    port: (<AddressInfo>server.address()).port,
+    port: (server.address() as AddressInfo).port,
     headers: {
       'Content-Type': 'application/json',
     },

packages/css/tests/tools/tester/tester.ts

@@ -29,7 +29,7 @@ export type InvalidAssertion = {
 class StylelintRuleTester {
   private readonly config: stylelint.Config;
 
-  constructor(rule: { ruleName: string; rule: stylelint.Rule<any, any> }) {
+  constructor(rule: { ruleName: string; rule: stylelint.Rule }) {
     stylelint.rules[rule.ruleName] = rule.rule;
     this.config = { rules: { [rule.ruleName]: true } };
   }

packages/jsts/src/rules/helpers/ast.ts

@@ -412,7 +412,6 @@ function resolveIdentifiersAcc(
   }
 }
 
-// TODO Drop this function and replace it with `getProperty`
 export function getObjectExpressionProperty(
   node: estree.Node | undefined | null,
   propertyKey: string,

packages/jsts/tests/tools/sonar-runtime/rule/no-missing-sonar-runtime.ts

@@ -61,20 +61,22 @@ export const rule: Rule.RuleModule = {
           return;
         }
         const maybeMeta = getObjectExpressionProperty(node, 'meta');
-        if (maybeMeta) {
-          const maybeSchema = getObjectExpressionProperty(maybeMeta.value, 'schema');
-          if (maybeSchema && maybeSchema.value.type === 'ArrayExpression') {
-            const schema = maybeSchema.value;
-            for (const element of schema.elements) {
-              const maybeEnum = getObjectExpressionProperty(element, 'enum');
-              if (maybeEnum) {
-                isSecondaryLocationEnabled =
-                  maybeEnum.value.type === 'ArrayExpression' &&
-                  maybeEnum.value.elements.length === 1 &&
-                  maybeEnum.value.elements[0].type === 'Identifier' &&
-                  maybeEnum.value.elements[0].name === 'SONAR_RUNTIME';
-              }
-            }
+        if (!maybeMeta) {
+          return;
+        }
+        const maybeSchema = getObjectExpressionProperty(maybeMeta.value, 'schema');
+        if (maybeSchema?.value.type !== 'ArrayExpression') {
+          return;
+        }
+        const schema = maybeSchema.value;
+        for (const element of schema.elements) {
+          const maybeEnum = getObjectExpressionProperty(element, 'enum');
+          if (maybeEnum) {
+            isSecondaryLocationEnabled =
+              maybeEnum.value.type === 'ArrayExpression' &&
+              maybeEnum.value.elements.length === 1 &&
+              maybeEnum.value.elements[0].type === 'Identifier' &&
+              maybeEnum.value.elements[0].name === 'SONAR_RUNTIME';
           }
         }
       },

packages/jsts/tests/tools/testers/comment-based/checker.ts

@@ -39,7 +39,7 @@ const ruleTester = new RuleTester({ parser: __filename });
 export function check(ruleId: string, ruleModule: Rule.RuleModule, ruleDir: string) {
   const fixtures = [];
   for (const file of fs.readdirSync(ruleDir)) {
-    if (file.match(/\.fixture\.(js|ts|jsx|tsx|vue)$/)) {
+    if (/\.fixture\.(js|ts|jsx|tsx|vue)$/.exec(file)) {
       const fixture = path.join(ruleDir, file);
       fixtures.push(fixture);
     }

packages/jsts/tests/tools/testers/comment-based/helpers/issues.ts

@@ -84,7 +84,7 @@ export function isNonCompliantLine(comment: string) {
 }
 
 export function extractLineIssues(file: FileIssues, comment: Comment) {
-  const matcher = comment.value.match(NON_COMPLIANT_PATTERN);
+  const matcher = NON_COMPLIANT_PATTERN.exec(comment.value);
   if (matcher === null) {
     throw new Error(`Invalid comment format at line ${comment.line}: ${comment.value}`);
   }

packages/jsts/tests/tools/testers/comment-based/helpers/locations.ts

@@ -51,10 +51,6 @@ export abstract class Location {
 
 export class PrimaryLocation extends Location {
   readonly secondaryLocations: SecondaryLocation[] = [];
-
-  constructor(range: Range) {
-    super(range);
-  }
 }
 
 export class SecondaryLocation extends Location {
@@ -79,7 +75,7 @@ export function extractLocations(file: FileIssues, comment: Comment) {
   let offset = 0;
   let matcher: RegExpMatchArray | null;
   LOCATION_PATTERN.lastIndex = 0;
-  while ((matcher = toBeMatched.match(LOCATION_PATTERN)) !== null) {
+  while ((matcher = LOCATION_PATTERN.exec(toBeMatched)) !== null) {
     locations.push(
       matcherToLocation(line, column, commentContent.indexOf(matcher[1], offset) + 1, matcher),
     );

packages/jsts/tests/tools/testers/comment-based/helpers/quickfixes.ts

@@ -75,7 +75,7 @@ export function isQuickfixLine(comment: string) {
 
 export function extractQuickFixes(quickfixes: Map<string, QuickFix>, comment: Comment) {
   if (QUICKFIX_DESCRIPTION_PATTERN.test(comment.value)) {
-    const matches = comment.value.match(QUICKFIX_DESCRIPTION_PATTERN);
+    const matches = QUICKFIX_DESCRIPTION_PATTERN.exec(comment.value);
     const { quickfixId, message } = matches.groups;
     const quickfix = quickfixes.get(quickfixId);
     if (!quickfix) {
@@ -87,7 +87,7 @@ export function extractQuickFixes(quickfixes: Map<string, QuickFix>, comment: Co
     }
     quickfix.description = message;
   } else if (QUICKFIX_CHANGE_PATTERN.test(comment.value)) {
-    const matches = comment.value.match(QUICKFIX_CHANGE_PATTERN);
+    const matches = QUICKFIX_CHANGE_PATTERN.exec(comment.value);
     const {
       quickfixId,
       type,

packages/jsts/tests/tools/testers/typescript/tester.ts

@@ -45,7 +45,7 @@ class TypeScriptRuleTester extends RuleTester {
     super({
       env,
       parser,
-      parserOptions: parserOptions,
+      parserOptions,
     });
   }
 

packages/shared/tests/helpers/debug.test.ts

@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software Foundation,
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
-import { debug } from '../../src/helpers';
+import { debug, info, warn } from '../../src/helpers';
 
 describe('debug', () => {
   it('should log with a `DEBUG` prefix', () => {
@@ -26,3 +26,19 @@ describe('debug', () => {
     expect(console.log).toHaveBeenCalledWith(`DEBUG hello, world!`);
   });
 });
+
+describe('warn', () => {
+  it('should log with a `WARN` prefix', () => {
+    console.log = jest.fn();
+    warn('hello, world!');
+    expect(console.log).toHaveBeenCalledWith(`WARN hello, world!`);
+  });
+});
+
+describe('info', () => {
+  it('should log with no prefix', () => {
+    console.log = jest.fn();
+    info('hello, world!');
+    expect(console.log).toHaveBeenCalledWith(`hello, world!`);
+  });
+});

pom.xml

@@ -86,6 +86,7 @@
     <sonar.javascript.lcov.reportPaths>coverage/lcov.info</sonar.javascript.lcov.reportPaths>
     <sonar.typescript.tsconfigPath>${project.basedir}/packages/tsconfig.app.json,${project.basedir}/packages/tsconfig.test.json</sonar.typescript.tsconfigPath>
     <sonar.cpd.exclusions>sonar-plugin/javascript-checks/src/main/resources/**/*.html</sonar.cpd.exclusions>
+    <sonar.coverage.exclusions>packages/bridge/src/worker.js</sonar.coverage.exclusions>
   </properties>
 
   <dependencyManagement>