Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the time complexity of the sanity check for mapped rules #4351

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

No description provided.

Copy link

sonarqube-next bot commented Nov 2, 2023

Quality Gate passed Quality Gate passed

Kudos, no new issues are introduced in this PR!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

Copy link
Contributor

@ilia-kebets-sonarsource ilia-kebets-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally they have the same performance, I believe because the bottleneck is the synchronous I/O during the rules load, but it might be better if we one day hit 10k rules or more.

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource merged commit 19fde5d into master Nov 2, 2023
16 checks passed
@yassin-kammoun-sonarsource yassin-kammoun-sonarsource deleted the improve-sanity-check branch November 2, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants