Modify S1874: Merge with react/no-deprecated
#4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ruling results
yassin-kammoun-sonarsource
approved these changes
Nov 15, 2023
|
|
||
| const sonarId = path.basename(__dirname); | ||
|
|
||
| describe(`Rule ${sonarId}`, () => { | ||
| searchPackageJsonFiles(__dirname, []); |
There was a problem hiding this comment.
Just a suggestion, but we could call in the beforeAll hook and then clear the database in the afterAll hook.
There was a problem hiding this comment.
not sure we can do that... comment base will then clear before each noncompliant, right? and we can use same DB for all
There was a problem hiding this comment.
oh, you mean beforeAll and not beforeEach, sorry yes you're right
also, just checked and indeed it just creates one test, not multiple, so beforeEach would also work
|
94.6% Coverage on New Code
0.0% Duplication on New Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3658