Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve S1874 (deprecation): Remove references from React no-deprecated messages #4392

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Improve S1874 (deprecation): Remove references from React no-deprecated messages #4392

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1cf273
Remove references from React no-deprecated messages
vdiez Nov 16, 2023
3826221
add assertion for new message
vdiez Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/jsts/src/rules/S1874/rule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ const reactNoDeprecated = rules['no-deprecated'];

export const rule: Rule.RuleModule = {
meta: {
messages: { ...reactNoDeprecated.meta!.messages, ...diagnosticsRule.meta!.messages },
messages: {
deprecated: '{{oldMethod}} is deprecated since React {{version}}{{newMethod}}',
...diagnosticsRule.meta!.messages,
},
},
create(context: Rule.RuleContext) {
function getVersionFromOptions() {
Expand Down