Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP S6479 (no-array-index-key) - Allow keys combining index and other values #4556

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

ericmorand-sonarsource
Copy link
Contributor

@ericmorand-sonarsource ericmorand-sonarsource commented Feb 5, 2024

Fixes #4510

@ericmorand-sonarsource ericmorand-sonarsource self-assigned this Feb 5, 2024
@ericmorand-sonarsource ericmorand-sonarsource changed the title Fix FP S4679 (no-array-index-key) - Allow keys combining index and … Fix FP S4679 (no-array-index-key) - Allow keys combining index and other values Feb 5, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny thing to fix, but lgtm otherwise!

packages/jsts/src/rules/S6479/rule.ts Outdated Show resolved Hide resolved
Co-authored-by: Yassin Kammoun <52890329+yassin-kammoun-sonarsource@users.noreply.github.com>
@ericmorand-sonarsource ericmorand-sonarsource changed the title Fix FP S4679 (no-array-index-key) - Allow keys combining index and other values Fix FP S6479 (no-array-index-key) - Allow keys combining index and other values Feb 5, 2024
@ericmorand-sonarsource
Copy link
Contributor Author

I checked each changed integration test expectation to ensure that they are legit.

@ericmorand-sonarsource ericmorand-sonarsource merged commit 371e71e into master Feb 6, 2024
14 checks passed
@ericmorand-sonarsource ericmorand-sonarsource deleted the issue-4510 branch February 6, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FP S6479 (no-array-index-key): Allow keys combining index and other values
2 participants