Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP S6606 (prefer-nullish-coalescing): When the first argument s boolean | undefined #4565

Merged
merged 5 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 6 additions & 77 deletions its/ruling/src/test/expected/jsts/ant-design/typescript-S6606.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
"ant-design:components/_util/statusUtils.tsx": [
23
],
"ant-design:components/affix/index.tsx": [
80
],
"ant-design:components/alert/ErrorBoundary.tsx": [
34
],
Expand All @@ -16,8 +13,7 @@
149
],
"ant-design:components/cascader/index.tsx": [
217,
221
217
],
"ant-design:components/descriptions/index.tsx": [
38,
Expand All @@ -35,17 +31,9 @@
86,
87
],
"ant-design:components/input/Input.tsx": [
93
],
"ant-design:components/list/index.tsx": [
194,
221,
266
],
"ant-design:components/locale-provider/LocaleReceiver.tsx": [
59
],
"ant-design:components/menu/SubMenu.tsx": [
78
],
Expand All @@ -72,99 +60,40 @@
25
],
"ant-design:components/progress/progress.tsx": [
81,
91
],
"ant-design:components/radio/radio.tsx": [
53
81
],
"ant-design:components/space/index.tsx": [
37
],
"ant-design:components/spin/index.tsx": [
113
],
"ant-design:components/statistic/utils.tsx": [
40
],
"ant-design:components/table/Table.tsx": [
148,
174,
282
],
"ant-design:components/table/hooks/useFilter/FilterDropdown.tsx": [
161,
182,
240,
256,
269,
282,
395,
410
],
"ant-design:components/table/hooks/useFilter/index.tsx": [
134,
149
174
],
"ant-design:components/table/hooks/usePagination.ts": [
81
],
"ant-design:components/table/hooks/useSelection.tsx": [
63,
99,
115,
115,
172
],
"ant-design:components/table/hooks/useSorter.tsx": [
144
],
"ant-design:components/tabs/index.tsx": [
65
],
"ant-design:components/transfer/ListItem.tsx": [
37,
58,
78
],
"ant-design:components/transfer/index.tsx": [
133,
379
],
"ant-design:components/transfer/operation.tsx": [
38,
48
],
"ant-design:components/tree-select/index.tsx": [
159,
162
159
],
"ant-design:components/typography/Base/index.tsx": [
207,
244,
246
207
],
"ant-design:components/upload/UploadList/ListItem.tsx": [
104,
120,
205
],
"ant-design:components/upload/utils.tsx": [
48,
57,
57
],
"ant-design:site/theme/template/Home/DesignPage/InteractiveIcon.tsx": [
38
],
"ant-design:site/theme/template/Layout/Header/algolia-config.ts": [
6
],
"ant-design:site/theme/template/utils.tsx": [
31,
31,
61,
78,
91
31
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
],
"courselit:apps/web/lib/graphql.ts": [
103,
105,
106
]
}
89 changes: 4 additions & 85 deletions its/ruling/src/test/expected/jsts/desktop/typescript-S6606.json
Original file line number Diff line number Diff line change
@@ -1,32 +1,21 @@
{
"desktop:app/src/cli/commands/help.ts": [
59
],
"desktop:app/src/highlighter/index.ts": [
512,
513
],
"desktop:app/src/lib/actions-log-parser/action-log-parser.ts": [
97,
519
97
],
"desktop:app/src/lib/api.ts": [
1484,
1667,
1789
1667
],
"desktop:app/src/lib/branch.ts": [
42
],
"desktop:app/src/lib/ci-checks/ci-checks.ts": [
656
],
"desktop:app/src/lib/editors/lookup.ts": [
58
],
"desktop:app/src/lib/find-account.ts": [
62
],
"desktop:app/src/lib/format-commit-message.ts": [
31
],
Expand All @@ -53,23 +42,10 @@
"desktop:app/src/lib/git/rebase.ts": [
572
],
"desktop:app/src/lib/git/spawn.ts": [
125
],
"desktop:app/src/lib/git/stash.ts": [
106,
169
],
"desktop:app/src/lib/git/status.ts": [
104,
117
],
"desktop:app/src/lib/helpers/pull-request-matching.ts": [
25
],
"desktop:app/src/lib/highlighter/worker.ts": [
44
],
"desktop:app/src/lib/http.ts": [
68,
69
Expand All @@ -78,14 +54,10 @@
130,
158
],
"desktop:app/src/lib/menu-update.ts": [
43
],
"desktop:app/src/lib/source-map-support.ts": [
127
],
"desktop:app/src/lib/stats/stats-store.ts": [
418,
541,
542,
1921
Expand All @@ -95,12 +67,6 @@
],
"desktop:app/src/lib/stores/app-store.ts": [
1200,
2095,
2104,
2671,
2684,
3123,
3303,
3961,
4867,
4897,
Expand All @@ -109,27 +75,13 @@
6613,
6644
],
"desktop:app/src/lib/stores/cloning-repositories-store.ts": [
68
],
"desktop:app/src/lib/stores/git-store.ts": [
477,
864,
1080,
1090,
1171,
1242
1090
],
"desktop:app/src/lib/stores/github-user-store.ts": [
67,
108
],
"desktop:app/src/lib/stores/helpers/find-default-remote.ts": [
15
],
"desktop:app/src/lib/stores/pull-request-coordinator.ts": [
250
],
"desktop:app/src/lib/stores/repositories-store.ts": [
374
],
Expand All @@ -154,44 +106,19 @@
"desktop:app/src/ui/app-menu/app-menu.tsx": [
290
],
"desktop:app/src/ui/app.tsx": [
812
],
"desktop:app/src/ui/autocompletion/user-autocompletion-provider.tsx": [
59
],
"desktop:app/src/ui/branches/branch-list.tsx": [
144
],
"desktop:app/src/ui/branches/pull-request-list-item.tsx": [
150
],
"desktop:app/src/ui/branches/pull-request-list.tsx": [
343
],
"desktop:app/src/ui/check-runs/ci-check-run-list.tsx": [
124
],
"desktop:app/src/ui/clone-repository/cloneable-repository-filter-list.tsx": [
111
],
"desktop:app/src/ui/create-tag/create-tag-dialog.tsx": [
46
],
"desktop:app/src/ui/dialog/dialog.tsx": [
368,
388,
388,
388
368
],
"desktop:app/src/ui/diff/diff-explorer.ts": [
41,
176,
194
],
"desktop:app/src/ui/dispatcher/error-handlers.ts": [
83
],
"desktop:app/src/ui/lib/author-input.tsx": [
376
],
Expand Down Expand Up @@ -219,12 +146,6 @@
"desktop:app/src/ui/lib/ref-name-text-box.tsx": [
63
],
"desktop:app/src/ui/lib/toggle-button.tsx": [
47
],
"desktop:app/src/ui/lib/update-store.ts": [
89
],
"desktop:app/src/ui/main-process-proxy.ts": [
303
],
Expand All @@ -238,9 +159,7 @@
"desktop:app/src/ui/repositories-list/group-repositories.ts": [
82,
90,
92,
139,
153,
160
],
"desktop:app/src/ui/repository-settings/repository-settings.tsx": [
Expand Down
13 changes: 0 additions & 13 deletions its/ruling/src/test/expected/jsts/eigen/typescript-S6606.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
"eigen:dangerfile.ts": [
131
],
"eigen:src/app/Components/ArtworkFilter/Filters/YearOptions.tsx": [
66,
67
],
"eigen:src/app/Components/ArtworkGrids/ArtworkGridItem.tests.tsx": [
263
],
Expand All @@ -28,15 +24,6 @@
"eigen:src/app/Scenes/Artwork/Components/PartnerCard.tsx": [
117
],
"eigen:src/app/Scenes/City/Components/AllEvents.tsx": [
77
],
"eigen:src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionArtworkHeader.tsx": [
58
],
"eigen:src/app/Scenes/Sale/Components/SaleLotsList.tsx": [
96
],
"eigen:src/app/Scenes/SellWithArtsy/SubmitArtwork/ArtworkDetails/utils/createOrUpdateSubmission.ts": [
41
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,35 +3,7 @@
42
],
"postgraphql:src/graphql/schema/createGqlSchema.ts": [
36,
37,
38,
40,
41
],
"postgraphql:src/graphql/schema/createMutationGqlField.ts": [
76
],
"postgraphql:src/graphql/schema/createMutationPayloadGqlType.ts": [
35
],
"postgraphql:src/postgraphql/postgraphql.ts": [
58,
82
],
"postgraphql:src/postgraphql/schema/createPostGraphQLSchema.ts": [
51,
137
],
"postgraphql:src/postgres/inventory/addPgCatalogToInventory.ts": [
18
],
"postgraphql:src/postgres/inventory/collection/PgCollectionKey.ts": [
200
],
"postgraphql:src/postgres/inventory/paginator/PgCollectionPaginator.ts": [
106,
111
36
],
"postgraphql:src/postgres/inventory/paginator/PgPaginatorOrderingAttributes.ts": [
34
Expand Down
Loading
Loading