Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reserved domain patterns to EXCEPTION_TOP_HOSTS list #4594

Closed

Conversation

wozitto
Copy link
Contributor

@wozitto wozitto commented Mar 10, 2024

SonarSource Community Forum Topic:
https://community.sonarsource.com/t/adding-reserved-domain-patterns-to-sonarqubes-security-exception-list/110822/1

This PR addresses the need to align our security exception list with the reserved domain names outlined in RFC 2606.
By incorporating these changes, we aim to reduce false positives in security checks and ensure that our practices are consistent with established internet standards.

Changes:

  • Updated the EXCEPTION_TOP_HOSTS array to include the .test and .example top-level domains (TLDs) as exceptions.
  • Added test cases to validate that URLs containing these TLDs are correctly handled as non-sensitive and do not trigger security warnings.

@wozitto wozitto marked this pull request as ready for review March 10, 2024 03:58
@vdiez
Copy link
Contributor

vdiez commented Mar 15, 2024

Thank you for providing this PR. I'll close this. Cherry picked your changes in #4597

@vdiez vdiez closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants