Change message to suggest upgrading to LTS version and not mention minimum version #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zglicz
approved these changes
Mar 25, 2024
| @@ -112,7 +112,9 @@ void test_min_version() throws IOException { | |||
| builder().minNodeVersion(Version.create(99, 0)).pathResolver(getPathResolver()).build() | |||
| ) | |||
| .isInstanceOf(NodeCommandException.class) | |||
| .hasMessageStartingWith("Only Node.js v99.0 or later is supported, got"); | |||
There was a problem hiding this comment.
well, this was future-proof
...ascript-plugin/src/main/java/org/sonar/plugins/javascript/nodejs/NodeCommandBuilderImpl.java
Outdated
Show resolved
Hide resolved
| @@ -112,7 +112,9 @@ void test_min_version() throws IOException { | |||
| builder().minNodeVersion(Version.create(99, 0)).pathResolver(getPathResolver()).build() | |||
| ) | |||
| .isInstanceOf(NodeCommandException.class) | |||
| .hasMessageStartingWith("Only Node.js v99.0 or later is supported, got"); | |||
| .hasMessageMatching( | |||
| "Unsupported Node.JS version detected .* Please upgrade to latest Node.JS LTS version." | |||
…lugins/javascript/nodejs/NodeCommandBuilderImpl.java Co-authored-by: zglicz <michal.zgliczynski@sonarsource.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.