Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS-379 Merge file traversals to count project size and tsconfigs together #4888

Merged
merged 10 commits into from
Nov 4, 2024
Merged

JS-379 Merge file traversals to count project size and tsconfigs together #4888

merged 10 commits into from
Nov 4, 2024

Conversation

zglicz
Copy link
Contributor

@zglicz zglicz commented Oct 31, 2024 •
edited by jira bot
Loading

@zglicz zglicz requested a review from a team October 31, 2024 11:18
@zglicz zglicz marked this pull request as ready for review October 31, 2024 11:18
vdiez
vdiez requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but I have doubts about the need to double the exclusions, specially because this impacts how the user need to pass properties. We can have a look on Monday on how to make it work with the already existing glob

...gin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptPlugin.java Outdated
@@ -121,10 +120,15 @@ public class JavaScriptPlugin implements Plugin {
public static final String TS_EXCLUSIONS_KEY = "sonar.typescript.exclusions";
public static final String[] EXCLUSIONS_DEFAULT_VALUE = new String[] {
"**/node_modules/**",
"**/node_modules",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to rethink this. Users adding exclusions will not be aware that they need to be repeated with both globs.

.../sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/JsTsSensor.java
@@ -57,30 +56,11 @@ public JsTsSensor(
AnalysisWithProgram analysisWithProgram,
AnalysisWithWatchProgram analysisWithWatchProgram,
AnalysisConsumers consumers
) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove comment at the top of constructor

vdiez
vdiez approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@vdiez vdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Nov 4, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
4 Fixed issues
1 Accepted issue

Measures
0 Security Hotspots
98.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@zglicz zglicz merged commit 7c2fc15 into master Nov 4, 2024
16 of 17 checks passed
@zglicz zglicz deleted the better-cache branch November 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdiez vdiez vdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zglicz @vdiez