JS-380 Bundle bridge using esbuild #4901
Conversation
vdiez
force-pushed
the
bundle-esbuild
branch
2 times, most recently
from
407d8c8 to
02e2a0c
Compare
| @@ -0,0 +1 @@ | |||
| declare module 'postcss-syntax'; | |||
vdiez
force-pushed
the
bundle-esbuild
branch
from
fd32e65 to
89c9165
Compare
remove timeout
| include: /lib[\/\\]jsts[\/\\]src[\/\\]parsers[\/\\]ast\.js$/, | ||
| pattern: [['path.dirname(fileURLToPath(import.meta.url))', '__dirname']], | ||
| }), | ||
| // Simplify the loader function in babel. At the end it's just importing Babel parser |
There was a problem hiding this comment.
Do you think it would be worth to point a specific line in a github repo? Perhaps this way, if something changes, it would be a good starting point to investigate.
Also, it would be great, if we could assert that these replacements actually happened. If we could make the bundling fail if any of the replacements didn't occur....
document sources where bundler is replacing sourcecode
|
| @@ -20,9 +20,6 @@ exports.rules = [ | |||
| ], | |||
| }, | |||
| create(context) { | |||
There was a problem hiding this comment.
For posteriority, the lines below were removed because typescript isn't installed and available
| @@ -29,13 +29,10 @@ describe('createStylelintConfig', () => { | |||
| { key: 'bar', configurations: [42] }, | |||
| ]; | |||
| const config = createStylelintConfig(rules); | |||
| expect(config).toEqual({ | |||
| customSyntax: 'postcss-syntax', | |||
There was a problem hiding this comment.
we now pass the imported module and we can't really compare it
| @@ -70,7 +70,7 @@ export function buildSourceCode(input: JsTsAnalysisInput, language: JsTsLanguage | |||
| return parseForESLint( | |||
| input.fileContent, | |||
| parser.parse, | |||
| buildParserOptions({ parser: vueFile ? parsers.javascript.parser : undefined }, true), | |||
| buildParserOptions({ parser: vueFile ? parsers.javascript : undefined }, true), | |||
There was a problem hiding this comment.
Again, we want to pass in a resolved module. parsers.javascript.parser was the library name @babel/eslint-parser and it would get invoked dynamically and esbuild wouldn't be able to resolve it.
| server | ||
| .start(Number.parseInt(port), host, createWorker(new URL(import.meta.url), getContext())) | ||
| .catch(() => {}); | ||
| server.start(Number.parseInt(port), host, createWorker(new URL(import.meta.url), getContext())); |
There was a problem hiding this comment.
Consciously we remove the catch. There doesn't seem to be a benefit of silently swallowing the error.
| @@ -37,7 +37,7 @@ public class BundleImpl implements Bundle { | |||
|
|
|||
| // this archive is created in the bridge module | |||
| private static final String BUNDLE_LOCATION = "/sonarjs-1.0.0.tgz"; | |||
| private static final String DEFAULT_STARTUP_SCRIPT = "package/bin/server.mjs"; | |||
| private static final String DEFAULT_STARTUP_SCRIPT = "package/bin/server.cjs"; | |||
There was a problem hiding this comment.
One step forward, two steps back ...
| @@ -46,7 +46,7 @@ public class NodeCommandBuilderImpl implements NodeCommandBuilder { | |||
|
|
|||
| public static final String NODE_EXECUTABLE_DEFAULT = "node"; | |||
| private static final String NODE_EXECUTABLE_DEFAULT_MACOS = | |||
| "package/node_modules/run-node/run-node"; | |||
| "package/bin/run-node"; | |||
There was a problem hiding this comment.
run-node is now a part of our project, we don't need to expect it to be in the node_modules
JS-380