Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7117: "SizedBox" should be used to add a whitespace to a layout #4379

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 7, 2024

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@github-actions github-actions bot added the dart label Oct 7, 2024
@leveretka leveretka changed the title Create rule S7117 Create rule S7117: "SizedBox" should be used to add a whitespace to a layout Oct 9, 2024
@leveretka leveretka marked this pull request as ready for review October 9, 2024 14:50
Copy link
Contributor

@antonioaversa antonioaversa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice description!
I have left some suggestions, mostly to conform to the format of other Flutter rules.

rules/S7117/dart/rule.adoc Show resolved Hide resolved
rules/S7117/dart/rule.adoc Outdated Show resolved Hide resolved
rules/S7117/dart/rule.adoc Outdated Show resolved Hide resolved
rules/S7117/dart/rule.adoc Outdated Show resolved Hide resolved
leveretka and others added 2 commits October 9, 2024 17:53
Co-authored-by: Antonio Aversa <antonio.aversa@sonarsource.com>
@leveretka leveretka enabled auto-merge (squash) October 10, 2024 11:37
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@leveretka leveretka merged commit 8dfa2ff into master Oct 10, 2024
8 of 10 checks passed
@leveretka leveretka deleted the rule/add-RSPEC-S7117 branch October 10, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants