Modify rule S7007: Update example to trigger the rule #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While validating this rule, it was found that the noncompliant example in the RSPEC did not trigger. This is because the detection also looks for the secret ID, which is missing from the example. The example has now been updated to include a secret ID and it now correctly triggers the rule.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While validating this rule, it was found that the noncompliant example in the RSPEC did not trigger. This is because the detection also looks for the secret ID, which is missing from the example.
The example has now been updated to include a secret ID and it now correctly triggers the rule.
Review
A dedicated reviewer checked the rule description successfully for: