Fix S2583/S2589 FP: For loop with Array.Length

[Tim-Pohlmann]

The SE engine does not learn Array.Length which results in FPs.
This could be solved by tracking array sizes or by changing how the engine handles for-loops with unknown limits.

void Test()
{
    var ids = new int[1000];
    for (var i = 0; i < ids.Length; i++)
    {
        if (i % 100 != 0 || i <= 0)   // Noncompliant FP
        {
            System.Diagnostics.Debug.WriteLine(i);
        }
    }
}

Similar problems arise with C#12 collection expressions:

void CollectionExpressions(int[] array)
{
    int[] knownLength = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10];
    for (var i = 0; i < knownLength.Length; i++)
    {
        if (i > 5)                  // Noncompliant FP
        {
            Console.WriteLine(i);   // Secondary
        }
    }

    int[] unknownLength = [1, 2, .. array, 3, 4];
    for (var i = 0; i < unknownLength.Length; i++)
    {
        if (i > 5)                  // Noncompliant FP
        {
            Console.WriteLine(i);   // Secondary
        }
    }

    int[] knownLength2 = [1, 2, .. knownLength, 3, 4];
    for (var i = 0; i < knownLength.Length; i++)
    {
        if (i > 5)                  // Noncompliant FP
        {
            Console.WriteLine(i);   // Secondary
        }
    }
}

and inline arrays:

[System.Runtime.CompilerServices.InlineArray(10)]
public struct Buffer
{
    private int _element0;
}
var buffer = new Buffer(); // buffer.Length is 10

Originally reported here.