Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $(NugetPackageRoot) instead of $(NUGET_PACKAGES) #3226

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Use $(NugetPackageRoot) instead of $(NUGET_PACKAGES) #3226

merged 2 commits into from
Mar 17, 2020

Conversation

andrei-epure-sonarsource
Copy link
Contributor

@andrei-epure-sonarsource andrei-epure-sonarsource commented Mar 17, 2020 •
edited
Loading

Fixes #3032

cherry-pick #3217 to run CI

The short version is that you can not rely on $(NUGET_PACKAGES) to be configured, but you can on $(NugetPackageRoot) . By changing this (for building with ProtoBuf) i could compile (again) locally.

See: NuGet/Home#6301 (comment)

@andrei-epure-sonarsource andrei-epure-sonarsource changed the title Corniel/pr nuget envvar Use $(NugetPackageRoot) instead of $(NUGET_PACKAGES) Mar 17, 2020
@andrei-epure-sonarsource andrei-epure-sonarsource mentioned this pull request Mar 17, 2020
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@andrei-epure-sonarsource andrei-epure-sonarsource merged commit a198035 into master Mar 17, 2020
@andrei-epure-sonarsource andrei-epure-sonarsource deleted the corniel/pr-nuget-envvar branch March 17, 2020 15:55
@andrei-epure-sonarsource andrei-epure-sonarsource mentioned this pull request Mar 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove use of NUGET_PACKAGES environment variable
1 participant
@andrei-epure-sonarsource