Migrate S4158: Passing as argument removes constraint #7433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Pohlmann
commented
Jun 14, 2023
Comment on lines
-1
to
-30
| { | ||
| "issues": [ | ||
| { | ||
| "id": "S4158", | ||
| "message": "Remove this call, the collection is known to be empty here.", | ||
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\Configuration\MappingExpressionBase.cs", | ||
| "region": { | ||
| "startLine": 174, | ||
| "startColumn": 21, | ||
| "endLine": 174, | ||
| "endColumn": 42 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S4158", | ||
| "message": "Remove this call, the collection is known to be empty here.", | ||
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\TypeMap.cs", | ||
| "region": { | ||
| "startLine": 44, | ||
| "startColumn": 17, | ||
| "endLine": 44, | ||
| "endColumn": 38 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
Tim-Pohlmann
commented
Jun 14, 2023
Comment on lines
-1
to
-30
| { | ||
| "issues": [ | ||
| { | ||
| "id": "S4158", | ||
| "message": "Remove this call, the collection is known to be empty here.", | ||
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\Configuration\MappingExpressionBase.cs", | ||
| "region": { | ||
| "startLine": 174, | ||
| "startColumn": 21, | ||
| "endLine": 174, | ||
| "endColumn": 42 | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "S4158", | ||
| "message": "Remove this call, the collection is known to be empty here.", | ||
| "location": { | ||
| "uri": "sources\Automapper\src\AutoMapper\TypeMap.cs", | ||
| "region": { | ||
| "startLine": 44, | ||
| "startColumn": 17, | ||
| "endLine": 44, | ||
| "endColumn": 38 | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
pavel-mikula-sonarsource
requested changes
Jun 15, 2023
...yzer.Common/SymbolicExecution/Roslyn/RuleChecks/EmptyCollectionsShouldNotBeEnumeratedBase.cs
Outdated
Show resolved
Hide resolved
Tim-Pohlmann
force-pushed
the
Tim/S4158_PassedAsArgument
branch
from
1af7576
to
d37f90d
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_DictionarySet
branch
2 times, most recently
from
d219c8e
to
7ec4f7a
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_PassedAsArgument
branch
from
d37f90d
to
789c810
Compare
pavel-mikula-sonarsource
requested changes
Jun 15, 2023
...yzer.Common/SymbolicExecution/Roslyn/RuleChecks/EmptyCollectionsShouldNotBeEnumeratedBase.cs
Show resolved
Hide resolved
Tim-Pohlmann
force-pushed
the
Tim/S4158_DictionarySet
branch
from
7ec4f7a
to
7a4f791
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_PassedAsArgument
branch
from
789c810
to
f106c58
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_DictionarySet
branch
from
7a4f791
to
1c14c00
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_PassedAsArgument
branch
from
f106c58
to
91167ce
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_DictionarySet
branch
from
1c14c00
to
587cf1a
Compare
Tim-Pohlmann
force-pushed
the
Tim/S4158_PassedAsArgument
branch
from
91167ce
to
a04b607
Compare
pavel-mikula-sonarsource
approved these changes
Jun 16, 2023
Comment on lines
196
to
197
| validator.ValidateTag("AfterField", x => x.Should().BeNull()); | ||
| validator.ValidateTag("AfterStaticField", x => x.Should().BeNull()); |
There was a problem hiding this comment.
Clean as you code: This method should be refactored to use TagValue instead. The two will end up as .TagValue("AfterField").Should().HaveNoConstraint(), effectively ignoring the null implementation detail (this UT doesn't care)
There was a problem hiding this comment.
Same on few methods below - only those you've modified
| @@ -200,14 +200,14 @@ public void Test() | |||
| validator.TagStates("End").Should().SatisfyRespectively( | |||
| x => | |||
| { | |||
| x[validator.Symbol("ObjectField")].HasConstraint<ObjectConstraint>().Should().BeFalse(); | |||
| x[validator.Symbol("ObjectField")].Should().BeNull(); | |||
There was a problem hiding this comment.
All assertions in this UT should use .Should().HaveNoConstraint() instead of null, and Should.HaveOnlyConstraints(.....) for the rest
Tim-Pohlmann
force-pushed
the
Tim/S4158_PassedAsArgument
branch
from
665175c
to
11ff5ec
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7300
Draft because it relies on #7418