Fix S2368 FP/FN: Don't raise for extension methods and raise for constructors #8152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cristian-ambrosini-sonarsource
approved these changes
Oct 9, 2023
cristian-ambrosini-sonarsource
suggested changes
Oct 17, 2023
|
|
||
| protected override SyntaxToken GetIdentifier(MethodStatementSyntax method) => method.Identifier; | ||
| protected override Location GetIssueLocation(SyntaxNode node) => | ||
| node?.RemoveParentheses() switch |
There was a problem hiding this comment.
Here you are passing c.Node to the method which should be not null by design, so ? can be removed
|
|
||
| protected override SyntaxToken GetIdentifier(MethodStatementSyntax method) => method.Identifier; | ||
| protected override Location GetIssueLocation(SyntaxNode node) => | ||
| node?.RemoveParentheses() switch |
There was a problem hiding this comment.
Same for RemoveParentheses(), we are passing a MethodDeclaration or a ConstructorDeclaration so most probably it's not needed and can be removed
| protected override Location GetIssueLocation(SyntaxNode node) => | ||
| node?.RemoveParentheses() switch | ||
| { | ||
| ConstructorBlockSyntax x => x.SubNewStatement.NewKeyword.GetLocation(), |
There was a problem hiding this comment.
This logic could be also rewritten as a ternary, something similar to:
protected override Location GetIssueLocation(SyntaxNode node) =>
node is ConstructorBlockSyntax x
? x.SubNewStatement.NewKeyword.GetLocation()
: Language.Syntax.NodeIdentifier(node)?.GetLocation();
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
cristian-ambrosini-sonarsource
approved these changes
Oct 18, 2023
cristian-ambrosini-sonarsource
merged commit 5bf048e
into
SonarSource:master
24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7329
And handles ordinary constructor support from #8083