Optimization: Enable on-demand plugin download #8160
Conversation
gregory-paidis-sonarsource
force-pushed
the
greg/enable-on-demand-plugin-download
branch
from
90e594d to
d749e3b
Compare
pom.xml
Outdated
| @@ -6,7 +6,7 @@ | |||
| <parent> | |||
| <groupId>org.sonarsource.parent</groupId> | |||
| <artifactId>parent</artifactId> | |||
| <version>68.0.0.247</version> | |||
| <version>70.0.0.270</version> | |||
There was a problem hiding this comment.
Please bump this in a separate PR
There was a problem hiding this comment.
PR has been split
sonar-csharp-plugin/pom.xml
Outdated
| @@ -155,7 +155,8 @@ | |||
| <pluginClass>org.sonar.plugins.csharp.CSharpPlugin</pluginClass> | |||
| <skipDependenciesPackaging>true</skipDependenciesPackaging> | |||
| <sonarLintSupported>false</sonarLintSupported> | |||
| <sonarQubeMinVersion>${sonarLTS.version}</sonarQubeMinVersion> <!-- runtime minimal API version --> | |||
| <pluginApiMinVersion>${sonarLTS.version}</pluginApiMinVersion> <!-- runtime minimal API version --> | |||
There was a problem hiding this comment.
pluginApiMinVersion is not the same thing as SQ version. They have independent lifecycles now.
Hardcode the value here
There was a problem hiding this comment.
I think API version is in sonar.version property. Can you check with Cody if that's the case and having 10.1.0.809 would work here?
sonar-dotnet doesn't care about MIN Api version, because we do not run in Java SonarLint flavors, and we always run under the latest release of SQ/SC.
There was a problem hiding this comment.
I think it should be fine. In any case, it should not affect the on-demand downloading feature.
|
The PR title and the issue title are not in sync now. They should be (one or other way, or somewhere in between) |
gregory-paidis-sonarsource
changed the title
gregory-paidis-sonarsource
force-pushed
the
greg/enable-on-demand-plugin-download
branch
from
d749e3b to
5e9fae9
Compare
gregory-paidis-sonarsource
force-pushed
the
greg/enable-on-demand-plugin-download
branch
from
5e9fae9 to
2f9a626
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
gregory-paidis-sonarsource
deleted the
greg/enable-on-demand-plugin-download
branch
This reverts commit 85daca1.
Fixes #8038