Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve S2068 performance: Reuse compiled Regex #8185

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Improve S2068 performance: Reuse compiled Regex #8185

merged 14 commits into from
Nov 24, 2023

Conversation

martin-strecker-sonarsource
Copy link
Contributor

@martin-strecker-sonarsource martin-strecker-sonarsource commented Oct 11, 2023 •
edited
Loading

see also #8181 and #8183

Before:
image

After:
image

@martin-strecker-sonarsource martin-strecker-sonarsource added Area: VB.NET VB.NET rules related issues. Area: C# C# rules related issues. Type: Performance It takes too long. labels Oct 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

andrei-epure-sonarsource
andrei-epure-sonarsource reviewed Nov 3, 2023
View reviewed changes
analyzers/src/SonarAnalyzer.Common/Rules/Hotspots/DoNotHardcodeCredentialsBase.cs Outdated
private const string DefaultCredentialWords = "password, passwd, pwd, passphrase";
private static readonly ConcurrentDictionary<string, Regex> PasswordValuePattern = new();
protected static readonly Regex ValidCredentialPattern = new(@"^(\?|:\w+|\{\d+[^}]*\}|""|')$", RegexOptions.IgnoreCase | RegexOptions.Compiled);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #8314 to deal with the timeouts. It should be a small easy change.

@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request Nov 17, 2023
Merged
sebastien-marichal
sebastien-marichal approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@sebastien-marichal sebastien-marichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pavel-mikula-sonarsource
pavel-mikula-sonarsource requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the concurrent dictionary

@antonioaversa antonioaversa changed the title DoNotHardcodeCredentials: Reuse compiled Regex Improve S2068 performance: Reuse compiled Regex Nov 23, 2023
@antonioaversa antonioaversa modified the milestone: 9.14 Nov 23, 2023
pavel-mikula-sonarsource
pavel-mikula-sonarsource approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let you deal with the hotspots before merging (I'm not sure what the correct resolution for hotspots is in the new CaYC QG)

analyzers/src/SonarAnalyzer.Common/Rules/Hotspots/DoNotHardcodeCredentialsBase.cs Outdated Show resolved Hide resolved
@martin-strecker-sonarsource @pavel-mikula-sonarsource
Update analyzers/src/SonarAnalyzer.Common/Rules/Hotspots/DoNotHardcod…
021fccf 
…eCredentialsBase.cs

Co-authored-by: Pavel Mikula <57188685+pavel-mikula-sonarsource@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@martin-strecker-sonarsource martin-strecker-sonarsource merged commit fe74751 into master Nov 24, 2023
24 checks passed
@martin-strecker-sonarsource martin-strecker-sonarsource deleted the Martin/DoNotHardcodeCredentials_Static branch November 24, 2023 13:53
@sebastien-marichal sebastien-marichal added this to the 9.15 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource left review comments

@pavel-mikula-sonarsource pavel-mikula-sonarsource pavel-mikula-sonarsource approved these changes

@sebastien-marichal sebastien-marichal sebastien-marichal approved these changes

Assignees

@martin-strecker-sonarsource martin-strecker-sonarsource

Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.
Projects
None yet
Milestone
9.15
Development

Successfully merging this pull request may close these issues.
5 participants
@martin-strecker-sonarsource @andrei-epure-sonarsource @pavel-mikula-sonarsource @sebastien-marichal @antonioaversa