Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE: Move CollectionConstraint from S4158 to the engine (part 2) #8704

Merged

Conversation

gregory-paidis-sonarsource
Copy link
Contributor

Part of #7866

Moves the following logic from the rule to the new ArrayCreation processor:

var foo = new int[2]; // not null, not empty
var bar = new int[0]; // not null, empty

@gregory-paidis-sonarsource gregory-paidis-sonarsource marked this pull request as ready for review February 6, 2024 16:30
@gregory-paidis-sonarsource gregory-paidis-sonarsource changed the base branch from master to greg/move-collection-constraint-1 February 6, 2024 16:31
@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/move-collection-constraint-2 branch 2 times, most recently from c56ec84 to fffcf84 Compare February 7, 2024 09:44
@gregory-paidis-sonarsource gregory-paidis-sonarsource force-pushed the greg/move-collection-constraint-2 branch 2 times, most recently from c86b162 to 6db10f8 Compare February 7, 2024 10:48
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your very own Processor :) LGTM!

Base automatically changed from greg/move-collection-constraint-1 to master February 7, 2024 15:57
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 7, 2024

@gregory-paidis-sonarsource gregory-paidis-sonarsource merged commit 8e87ce0 into master Feb 7, 2024
25 checks passed
@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the greg/move-collection-constraint-2 branch February 7, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants