Rule S6602: Update the message for arrays #8956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +50,8 @@ public abstract class FindInsteadOfFirstOrDefaultBase<TSyntaxKind, TInvocationEx | |||
| && IsCorrectType(left, c.SemanticModel) | |||
| && !Language.Syntax.IsInExpressionTree(c.SemanticModel, invocation)) | |||
| { | |||
| c.ReportIssue(Diagnostic.Create(Rule, Language.Syntax.NodeIdentifier(invocation)?.GetLocation())); | |||
| var message = c.SemanticModel.GetTypeInfo(left).Type.DerivesFrom(KnownType.System_Array) ? ArrayMessage : GenericMessage; | |||
| c.ReportIssue(Diagnostic.Create(Rule, Language.Syntax.NodeIdentifier(invocation)?.GetLocation(), message)); | |||
There was a problem hiding this comment.
What do you think about refactoring IsCorrectType to this?
private static bool IsCorrectType(SyntaxNode left, SemanticModel model, out bool isArray)
{
var type = model.GetTypeInfo(left).Type;
isArray = type.DerivesFrom(KnownType.System_Array);
return isArray || type.DerivesFromAny(ListTypes);
}This way you do the semantic check only once, and then use the boolean out parameter for your message ternary:
var message = isArray ? ArrayMessage : GenericMessage;There was a problem hiding this comment.
While your suggestion is more performant, I prefer to use the out parameters only if needed. The second call should be rather fast due to caching.
There was a problem hiding this comment.
It looks like the out parameter won 😱
costin-zaharia-sonarsource
force-pushed
the
costin/S6602-message
branch
from
f3e8f1e
to
552f22d
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8935