Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics analyzer for Razor: Lines of code are outside the range of the file #9312

Merged
merged 10 commits into from
May 22, 2024

Conversation

costin-zaharia-sonarsource
Copy link
Member

@costin-zaharia-sonarsource costin-zaharia-sonarsource commented May 22, 2024

Chery picks:

I've manually tested the fix following these steps:

  • used the old version of the analyzer to reproduce the problem on the sonar-dotnet-shared-library\src\test\resources\RazorProtobufImporter\WebProject\ test project
  • build a new version of the analyzer (9.25.1)
  • updated a local version of SQ to use the latest version
  • re-analyzed the project. the mapping issue no longer fails the build

Copy link

sonarcloud bot commented May 22, 2024

Copy link

sonarcloud bot commented May 22, 2024

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMb

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit c1b8fd7 into branch-9.25 May 22, 2024
29 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the costin/hotfix branch May 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants