Fix S6934 FP: Route attributes derived from IRouteTemplateProvider

analyzers/src/SonarAnalyzer.CSharp/Rules/AspNet/SpecifyRouteAttribute.cs

@@ -27,10 +27,6 @@ public sealed class SpecifyRouteAttribute() : SonarDiagnosticAnalyzer<SyntaxKind
 {
     private const string DiagnosticId = "S6934";
 
-    private static readonly ImmutableArray<KnownType> RouteTemplateAttributes = ImmutableArray.Create(
-        KnownType.Microsoft_AspNetCore_Mvc_Routing_HttpMethodAttribute,
-        KnownType.Microsoft_AspNetCore_Mvc_RouteAttribute);
-
     protected override string MessageFormat => "Specify the RouteAttribute when an HttpMethodAttribute or RouteAttribute is specified at an action level.";
     protected override ILanguageFacade<SyntaxKind> Language => CSharpFacade.Instance;
 
@@ -43,7 +39,7 @@ protected override void Initialize(SonarAnalysisContext context) =>
             }
             compilationStart.RegisterSymbolStartAction(symbolStart =>
             {
-                if (symbolStart.Symbol.GetAttributesWithInherited().Any(x => x.AttributeClass.Is(KnownType.Microsoft_AspNetCore_Mvc_RouteAttribute)))
+                if (symbolStart.Symbol.GetAttributesWithInherited().Any(x => x.AttributeClass.DerivesOrImplements(KnownType.Microsoft_AspNetCore_Mvc_Routing_IRouteTemplateProvider)))
                 {
                     return;
                 }
@@ -54,7 +50,7 @@ protected override void Initialize(SonarAnalysisContext context) =>
                     if (nodeContext.SemanticModel.GetDeclaredSymbol(methodDeclaration, nodeContext.Cancel) is { } method
                         && !method.ContainingType.IsAbstract
                         && method.IsControllerActionMethod()
-                        && method.GetAttributesWithInherited().Any(x => !CanBeIgnored(x.GetAttributeRouteTemplate(RouteTemplateAttributes))))
+                        && method.GetAttributesWithInherited().Any(x => !CanBeIgnored(x.GetAttributeRouteTemplate())))
                     {
                         secondaryLocations.Push(methodDeclaration.Identifier.GetLocation());
                     }

analyzers/src/SonarAnalyzer.Common/Extensions/AttributeDataExtensions.cs

@@ -28,8 +28,8 @@ public static bool HasName(this AttributeData attribute, string name) =>
         public static bool HasAnyName(this AttributeData attribute, params string[] names) =>
             names.Any(x => attribute.HasName(x));
 
-        public static string GetAttributeRouteTemplate(this AttributeData attribute, ImmutableArray<KnownType> attributeTypes) =>
-            attribute.AttributeClass.DerivesFromAny(attributeTypes)
+        public static string GetAttributeRouteTemplate(this AttributeData attribute) =>
+            attribute.AttributeClass.DerivesOrImplementsAny(AspNetMvcHelper.RouteTemplateProviders)
             && attribute.TryGetAttributeValue<string>("template", out var template)
                 ? template
                 : null;

analyzers/src/SonarAnalyzer.Common/Helpers/AspNetMvcHelper.cs

@@ -22,11 +22,10 @@ namespace SonarAnalyzer.Helpers
 {
     public static class AspNetMvcHelper
     {
-        public static readonly ImmutableArray<KnownType> RouteTemplateAttributes =
+        public static readonly ImmutableArray<KnownType> RouteTemplateProviders =
             ImmutableArray.Create(
-                KnownType.Microsoft_AspNetCore_Mvc_Routing_HttpMethodAttribute,
-                KnownType.Microsoft_AspNetCore_Mvc_RouteAttribute,
-                KnownType.System_Web_Mvc_RouteAttribute);
+                KnownType.Microsoft_AspNetCore_Mvc_Routing_IRouteTemplateProvider,
+                KnownType.System_Web_Mvc_Routing_IRouteInfoProvider);
 
         private static readonly ImmutableArray<KnownType> ControllerTypes =
             ImmutableArray.Create(

analyzers/src/SonarAnalyzer.Common/Helpers/KnownType.cs

@@ -111,6 +111,7 @@ public sealed partial class KnownType
         public static readonly KnownType Microsoft_AspNetCore_Mvc_RequestSizeLimitAttribute = new("Microsoft.AspNetCore.Mvc.RequestSizeLimitAttribute");
         public static readonly KnownType Microsoft_AspNetCore_Mvc_RouteAttribute = new("Microsoft.AspNetCore.Mvc.RouteAttribute");
         public static readonly KnownType Microsoft_AspNetCore_Mvc_Routing_HttpMethodAttribute = new("Microsoft.AspNetCore.Mvc.Routing.HttpMethodAttribute");
+        public static readonly KnownType Microsoft_AspNetCore_Mvc_Routing_IRouteTemplateProvider = new("Microsoft.AspNetCore.Mvc.Routing.IRouteTemplateProvider");
         public static readonly KnownType Microsoft_AspNetCore_Razor_Hosting_RazorCompiledItemAttribute = new("Microsoft.AspNetCore.Razor.Hosting.RazorCompiledItemAttribute");
         public static readonly KnownType Microsoft_Azure_Cosmos_CosmosClient = new("Microsoft.Azure.Cosmos.CosmosClient");
         public static readonly KnownType Microsoft_Azure_Documents_Client_DocumentClient = new("Microsoft.Azure.Documents.Client.DocumentClient");
@@ -588,6 +589,7 @@ public sealed partial class KnownType
         public static readonly KnownType System_Web_Mvc_HttpPostAttribute = new("System.Web.Mvc.HttpPostAttribute");
         public static readonly KnownType System_Web_Mvc_NonActionAttribute = new("System.Web.Mvc.NonActionAttribute");
         public static readonly KnownType System_Web_Mvc_RouteAttribute = new("System.Web.Mvc.RouteAttribute");
+        public static readonly KnownType System_Web_Mvc_Routing_IRouteInfoProvider = new("System.Web.Mvc.Routing.IRouteInfoProvider");
         public static readonly KnownType System_Web_Mvc_RoutePrefixAttribute = new("System.Web.Mvc.RoutePrefixAttribute");
         public static readonly KnownType System_Web_Mvc_ValidateInputAttribute = new("System.Web.Mvc.ValidateInputAttribute");
         public static readonly KnownType System_Web_Script_Serialization_JavaScriptSerializer = new("System.Web.Script.Serialization.JavaScriptSerializer");

analyzers/src/SonarAnalyzer.Common/Rules/AspNet/RouteTemplateShouldNotStartWithSlashBase.cs

@@ -89,7 +89,7 @@ private static Dictionary<Location, string> RouteAttributeTemplateArguments(Immu
         var templates = new Dictionary<Location, string>();
         foreach (var attribute in attributes)
         {
-            if (attribute.GetAttributeRouteTemplate(AspNetMvcHelper.RouteTemplateAttributes) is { } templateParameter)
+            if (attribute.GetAttributeRouteTemplate() is { } templateParameter)
             {
                 templates.Add(attribute.ApplicationSyntaxReference.GetSyntax().GetLocation(), templateParameter);
             }

analyzers/tests/SonarAnalyzer.Test/TestCases/AspNet/SpecifyRouteAttribute.CSharp12.cs

@@ -222,10 +222,10 @@ public class ControllerOverridesActionWithRoute : BaseControllerWithActionWithRo
 public sealed class ExtendedRouteAttribute() : RouteAttribute("[controller]/[action]");
 
 [ExtendedRoute]
-public class SomeController : ControllerBase // Noncompliant, FP the route attribute template is set in the base class of ExtendedRouteAttribute
+public class SomeController : ControllerBase    // Compliant - the route attribute template is set in the base class of ExtendedRouteAttribute
 {
     [HttpGet("foo")]
-    public string Foo() => "Hi";            // Secondary
+    public string Foo() => "Hi";
 }
 
 // https://github.com/SonarSource/sonar-dotnet/issues/9252