Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S6964 FP: Properties decorated with the [BindNever] attribute #9361

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix S6964 FP: Properties decorated with the [BindNever] attribute #9361

merged 4 commits into from
May 30, 2024

Conversation

zsolt-kolbay-sonarsource
Copy link
Contributor

Fixes #9360

mary-georgiou-sonarsource
mary-georgiou-sonarsource requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see this again after rebase 🎉

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource force-pushed the Zsolt/fix-S6964-FP-BindNeverAttribute branch from cab38c0 to c8ad6c4 Compare May 30, 2024 13:22
mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a minor thing to fix also in another PR.

@zsolt-kolbay-sonarsource @mary-georgiou-sonarsource
Review
f14a622 
Co-authored-by: Mary Georgiou <89914005+mary-georgiou-sonarsource@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource merged commit 80811f9 into master May 30, 2024
26 checks passed
@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource deleted the Zsolt/fix-S6964-FP-BindNeverAttribute branch May 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S6964 FP: Properties decorated with the [BindNever] attribute
2 participants
@zsolt-kolbay-sonarsource @mary-georgiou-sonarsource