Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve S1694: Remove part about protected constructor #9387

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Improve S1694: Remove part about protected constructor #9387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98a8743
File-scoped namespaces
pavel-mikula-sonarsource Jun 4, 2024
15f6ea1
Cleanup
pavel-mikula-sonarsource Jun 4, 2024
0b24d09
Implement
pavel-mikula-sonarsource Jun 4, 2024
3b04e4f
File scoped namespaces, add locations
pavel-mikula-sonarsource Jun 4, 2024
d1844ad
Rspec update
pavel-mikula-sonarsource Jun 4, 2024
23d133d
Update ITs
pavel-mikula-sonarsource Jun 4, 2024
942b0ac
Review update
pavel-mikula-sonarsource Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions analyzers/its/expected/Automapper/S1694-AutoMapper-net461.json
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions analyzers/its/expected/Automapper/S1694-AutoMapper-netstandard2.0.json
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions analyzers/its/expected/CSharpLatest/S1694-CSharpLatest-net8.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@
"Message": "Convert this \u0027abstract\u0027 record to an interface.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/CSharpLatest/CSharpLatest/CSharp9Features/Records.cs#L35",
"Location": "Line 35 Position 24-38"
},
{
"Id": "S1694",
"Message": "Convert this \u0027abstract\u0027 class to a concrete type with a protected constructor.",
"Uri": "https://github.com/SonarSource/sonar-dotnet/blob/master/analyzers/its/Projects/CSharpLatest/CSharpLatest/CSharp9Features/S3240.cs#L5",
"Location": "Line 5 Position 20-25"
}
]
}
10 changes: 0 additions & 10 deletions analyzers/its/expected/CSharpLatest/S1694-Net5-net5.0.json
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions analyzers/its/expected/Nancy/S1694-Nancy-net452.json
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions analyzers/its/expected/Nancy/S1694-Nancy-netstandard2.0.json
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions analyzers/its/expected/Nancy/S1694-Nancy.Hosting.Aspnet-net452.json
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions analyzers/its/expected/Nancy/S1694-Nancy.Metadata.Modules-net452.json
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions analyzers/its/expected/Nancy/S1694-Nancy.Metadata.Modules-netstandard2.0.json
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions analyzers/its/expected/Nancy/S1694-Nancy.ViewEngines.Razor-net452.json
View file
Open in desktop

This file was deleted.

Loading
Loading