-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LVA: Refactor operation extensions #9480
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.Select(x => x.Instance.AsFlowCapture()) | ||
.OfType<IFlowCaptureOperationWrapper>()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OfType
is a hidden null check that doesn't remove the nullability problem. Make it .Where(x => x.Instance.IsKind(..)
and .Select(x => x.ToFlowCapture())
Quality Gate passed for 'Sonar .NET Java Plugin'Issues Measures |
Quality Gate passed for 'SonarAnalyzer for .NET'Issues Measures |
All the operation extension methods (except the ones that are based on ProgramState) are now in the Sonar.Analyzer CFG projects.