Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S1854 FN: Support &&, ||, ?? and ??= #9536

Merged
merged 4 commits into from
Jul 30, 2024
Merged

Fix S1854 FN: Support &&, ||, ?? and ??= #9536

merged 4 commits into from
Jul 30, 2024

Conversation

Tim-Pohlmann
Copy link
Contributor

Fixes #4937

@Tim-Pohlmann Tim-Pohlmann linked an issue Jul 19, 2024 that may be closed by this pull request
Fix S1854 FN: Support &&, ||, ?? and ??= #4937
Open
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/lva-flowcapture-reference branch 2 times, most recently from c2948b6 to fa2b72f Compare July 19, 2024 10:03
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/lva-flowcapture-assignment branch from 7a1c374 to 78b2c07 Compare July 19, 2024 10:13
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/lva-flowcapture-reference branch from c0e9298 to 7e9dca5 Compare July 19, 2024 10:13
Base automatically changed from Tim/lva-flowcapture-assignment to master July 19, 2024 12:58
@Tim-Pohlmann Tim-Pohlmann force-pushed the Tim/lva-flowcapture-reference branch from 7e9dca5 to 3cbf236 Compare July 19, 2024 13:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Pohlmann Tim-Pohlmann merged commit 2c9c49a into master Jul 30, 2024
20 checks passed
@Tim-Pohlmann Tim-Pohlmann deleted the Tim/lva-flowcapture-reference branch July 30, 2024 14:01
mary-georgiou-sonarsource added a commit that referenced this pull request Aug 2, 2024
@mary-georgiou-sonarsource
Revert "Fix S1854 FN: Support &&, ||, ?? and ??= (#9536)"
95b89ac 
This reverts commit 2c9c49a.
mary-georgiou-sonarsource added a commit that referenced this pull request Aug 2, 2024
@mary-georgiou-sonarsource
Revert "Fix S1854 FN: Support &&, ||, ?? and ??= (#9536)" (#9591)
56821c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

@pavel-mikula-sonarsource pavel-mikula-sonarsource Awaiting requested review from pavel-mikula-sonarsource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix S1854 FN: Support &&, ||, ?? and ??=
2 participants
@Tim-Pohlmann @mary-georgiou-sonarsource