SQ Plugin: Remove deprecated import of integration test coverage from plugins #9561
Conversation
mary-georgiou-sonarsource
force-pushed
the
mary/remove-it-test-import
branch
from
9131982
to
7986541
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/remove-it-test-import
branch
from
7986541
to
d09f5fc
Compare
|
I also checked S4NET for any appearance of |
|
|
| @@ -43,8 +43,7 @@ public void vbnet() { | |||
| UnitTestResultsProvider.DotNetUnitTestResultsAggregator.class, | |||
| UnitTestResultsImportSensor.class); | |||
| assertThat(propertyKeys(extensions)).containsOnly( | |||
| "sonar.vbnet.vstest.reportsPaths", | |||
| "sonar.vbnet.nunit.reportsPaths"); | |||
| "sonar.vbnet.vstest.reportsPaths", "sonar.vbnet.nunit.reportsPaths"); | |||
There was a problem hiding this comment.
@mary-georgiou-sonarsource do you find this to be more readable? personally I find separate lines to be more readable.
and on CodeCoverageProviderTest.java you kept separate lines
but indeed for two values, it's fine inline
There was a problem hiding this comment.
Exactly. That was my thinking—that there are only two values, and separating them into two lines is not really needed—it does not add much apart from an extra line.
However, if you think it's better to separate not only for readability but also for uniformity with other similar cases, I'll be happy to revert in one of the next PRs.
There was a problem hiding this comment.
I don't think we should spend too much time on discussing such topics and trying to "fix" them (very low-impact).
As long as we agree that generally we put things on multiple lines to increase readability (like when there's multiple cases)
Fixes #4685