Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S3459 FP: Support @ref bindings in razor files / partial Blazor components #9567

Closed
wants to merge 2 commits into from
Closed

Fix S3459 FP: Support @ref bindings in razor files / partial Blazor components #9567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c5f3f
Add reproducer
martin-strecker-sonarsource Jun 4, 2024
e52b12d
Fix UT
martin-strecker-sonarsource Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions analyzers/tests/SonarAnalyzer.Test/Rules/NotAssignedPrivateMemberTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ public void NotAssignedPrivateMember() =>
[TestMethod]
public void NotAssignedPrivateMember_CSharp9() =>
builder.AddPaths("NotAssignedPrivateMember.CSharp9.cs").WithOptions(ParseOptionsHelper.FromCSharp9).Verify();

[TestMethod]
public void NotAssignedPrivateMember_Razor() =>
builder.AddPaths("NotAssignedPrivateMember.razor", "NotAssignedPrivateMember.razor.cs").VerifyNoIssues();
#endif

[TestMethod]
Expand Down
3 changes: 3 additions & 0 deletions analyzers/tests/SonarAnalyzer.Test/TestCases/NotAssignedPrivateMember.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
@namespace Razor
<PageTitle @ref="@pageTitle">
</PageTitle>
20 changes: 20 additions & 0 deletions analyzers/tests/SonarAnalyzer.Test/TestCases/NotAssignedPrivateMember.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Components.Web;
using Microsoft.AspNetCore.Components;

namespace Razor
{
public partial class NotAssignedPrivateMember
{
private ElementReference pageTitle; // Compliant - Assigned in the generated code for the razor file.

public void Test()
{
Console.WriteLine(pageTitle.ToString());
}
}
}
Loading