Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for STIG standard #9584

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add support for STIG standard #9584

merged 2 commits into from
Aug 2, 2024

Conversation

Tim-Pohlmann
Copy link
Contributor

Fixes #9558

Copy link

sonarcloud bot commented Jul 31, 2024

Copy link

sonarcloud bot commented Jul 31, 2024

private static final String NO_TAGS_RULE_KEY = "S1048";
private static final String SINGLE_PARAM_RULE_KEY = "S1200";
private static final String MULTI_PARAM_RULE_KEY = "S110";

private static final SonarRuntime SONAR_RUNTIME = SonarRuntimeImpl.forSonarQube(Version.create(9, 9), SonarQubeSide.SCANNER, SonarEdition.COMMUNITY);
private static final SonarRuntime SONAR_RUNTIME = SonarRuntimeImpl.forSonarQube(Version.create(10, 10), SonarQubeSide.SCANNER, SonarEdition.COMMUNITY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is cleaner - but the STIG are being raised only from SQ 10.7+ while OWASP from 9.9+ so I'd keep this tests seperate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SONAR_RUNTIME is used for all tests in this file. Only a few of them are related to security standards. I don't think using multiple runtime objects is worthwhile unless there are some breaking changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's keep on single runtime - however I think we should split these tests to be on UT per standard.

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok but IMO we should keep tests seperate.

Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Load STIG standard after ACOMMONS-11 is done Load STIG standard Aug 2, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Load STIG standard Add support for STIG standard Aug 2, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 4f2b11b into master Aug 2, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load STIG standard after ACOMMONS-11 is done
2 participants