Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LVA: Add UTs after validation #9594

Merged
merged 1 commit into from
Aug 5, 2024
Merged

LVA: Add UTs after validation #9594

merged 1 commit into from
Aug 5, 2024

Conversation

Tim-Pohlmann
Copy link
Contributor

@Tim-Pohlmann Tim-Pohlmann commented Aug 2, 2024 •
edited
Loading

Relates to #4937

@Tim-Pohlmann Tim-Pohlmann added the Sprint: Hardening Fix FPs/FNs/improvements label Aug 2, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed for 'Sonar .NET Java Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed for 'SonarAnalyzer for .NET'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Pipeline if failing due to the wrong ci image.
Once it's fixed I'll rebase this and merge.

@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title Add more LVA related UTs LVA: Add more UTs after validation Aug 5, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource changed the title LVA: Add more UTs after validation LVA: Add UTs after validation Aug 5, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit e3a118b into master Aug 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

Assignees

@Tim-Pohlmann Tim-Pohlmann

Labels
Sprint: Hardening Fix FPs/FNs/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tim-Pohlmann @mary-georgiou-sonarsource