-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShimLayer: Add Sonar directory with our changes #9612
Conversation
@@ -1,138 +0,0 @@ | |||
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to Sonar
@@ -1,32 +0,0 @@ | |||
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to Sonar
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved. | ||
// Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
||
#nullable enable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to Sonar
@@ -1,29 +0,0 @@ | |||
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, replaced by TypeDeclarationSyntaxExtensions.cs from StyleCop
public const SyntaxKind InitAccessorDeclaration = (SyntaxKind)9060; | ||
public const SyntaxKind WithExpression = (SyntaxKind)9061; | ||
public const SyntaxKind WithInitializerExpression = (SyntaxKind)9062; | ||
public const SyntaxKind RecordClassDeclaration = (SyntaxKind)9063; | ||
public const SyntaxKind RecordDeclaration = (SyntaxKind)9063; // Sonar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to sync with StyleCop (and the SyntaxKind name based on Microsoft documentation)
namespace StyleCop.Analyzers.Lightup; | ||
|
||
// This is a temporary substitute for IOperationWrapper in case StyleCop will accept PR https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3381 | ||
public readonly struct IOperationWrapperSonar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public const SyntaxKind GreaterThanGreaterThanGreaterThanToken = (SyntaxKind)8286; | ||
public const SyntaxKind GreaterThanGreaterThanGreaterThanEqualsToken = (SyntaxKind)8287; | ||
public const SyntaxKind NameOfKeyword = (SyntaxKind)8434; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved our additions to a partial class SyntaxKindEx.cs
in Sonar folder to align this file with StyleCop
Quality Gate passed for 'Sonar .NET Java Plugin'Issues Measures |
Quality Gate passed for 'SonarAnalyzer for .NET'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #9596
Fixes #9598