Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShimLayer: Add Sonar directory with our changes #9612

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

CristianAmbrosini
Copy link
Contributor

Fixes #9596
Fixes #9598

@@ -1,138 +0,0 @@
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to Sonar

@@ -1,32 +0,0 @@
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to Sonar

// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
// Licensed under the MIT License. See LICENSE in the project root for license information.

#nullable enable

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to Sonar

@@ -1,29 +0,0 @@
// Copyright (c) Tunnel Vision Laboratories, LLC. All Rights Reserved.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, replaced by TypeDeclarationSyntaxExtensions.cs from StyleCop

public const SyntaxKind InitAccessorDeclaration = (SyntaxKind)9060;
public const SyntaxKind WithExpression = (SyntaxKind)9061;
public const SyntaxKind WithInitializerExpression = (SyntaxKind)9062;
public const SyntaxKind RecordClassDeclaration = (SyntaxKind)9063;
public const SyntaxKind RecordDeclaration = (SyntaxKind)9063; // Sonar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to sync with StyleCop (and the SyntaxKind name based on Microsoft documentation)

namespace StyleCop.Analyzers.Lightup;

// This is a temporary substitute for IOperationWrapper in case StyleCop will accept PR https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3381
public readonly struct IOperationWrapperSonar
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines -12 to -14
public const SyntaxKind GreaterThanGreaterThanGreaterThanToken = (SyntaxKind)8286;
public const SyntaxKind GreaterThanGreaterThanGreaterThanEqualsToken = (SyntaxKind)8287;
public const SyntaxKind NameOfKeyword = (SyntaxKind)8434;
Copy link
Contributor Author

@CristianAmbrosini CristianAmbrosini Aug 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved our additions to a partial class SyntaxKindEx.cs in Sonar folder to align this file with StyleCop

@CristianAmbrosini CristianAmbrosini marked this pull request as ready for review August 7, 2024 13:23
Copy link

sonarcloud bot commented Aug 7, 2024

Copy link

sonarcloud bot commented Aug 7, 2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@costin-zaharia-sonarsource costin-zaharia-sonarsource merged commit b26c926 into master Aug 7, 2024
24 checks passed
@costin-zaharia-sonarsource costin-zaharia-sonarsource deleted the cristian/update-shimlayer branch August 7, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants