Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-9614 Update README #47

Merged
merged 1 commit into from
Sep 21, 2023
Merged

SC-9614 Update README #47

merged 1 commit into from
Sep 21, 2023

Conversation

bogdanakushnir
Copy link
Contributor

List of checkpoints to verify/do before merging a PR.

Dev checklist

  • Write/update tests
  • Functional validation
  • Public documentation update
  • Private documentation update
  • Clean commits (should start with a ticket number, clear message, no fixup, wip)
  • Maximize code coverage as much as possible

Reviewer checklist

  • Code review
  • Functional validation
  • Check commits are clean

Steps to validate this PR

Fill-in how you performed the validation, and how the reviewer can replicate it:

  • All updated links are working
  • README updated according to the task description

nawar-hamo-sonarsource
nawar-hamo-sonarsource approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@nawar-hamo-sonarsource nawar-hamo-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bogdanakushnir bogdanakushnir merged commit e4882e1 into main Sep 21, 2023
10 checks passed
@bogdanakushnir bogdanakushnir deleted the feature/bogdana/SC-9614 branch September 21, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nawar-hamo-sonarsource nawar-hamo-sonarsource nawar-hamo-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdanakushnir @nawar-hamo-sonarsource