Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This repository is owned by the Analysis Experience squad #53

Merged
merged 1 commit into from
Mar 28, 2024
Merged

This repository is owned by the Analysis Experience squad #53

merged 1 commit into from
Mar 28, 2024

Conversation

claire-villard-sonarsource
Copy link
Contributor

List of checkpoint to verify/do before merging a PR.

Dev checklist

  • Write/update tests
  • Functional validation
  • Public documentation update
  • Private documentation update
  • Clean commits (should start with a ticket number, clear message, no fixup, wip)
  • Maximize code coverage as much as possible

Reviewer checklist

  • Code review
  • Functional validation
  • Check commits are clean

Steps to validate this PR

Fill-in how you performed the validation, and how the reviewer can replicate it:

  • [ ]

istvan-bodo-sonarsource
istvan-bodo-sonarsource approved these changes Mar 28, 2024
View reviewed changes
Copy link

@istvan-bodo-sonarsource istvan-bodo-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierre-guillot-gh pierre-guillot-gh merged commit 1602208 into main Mar 28, 2024
10 checks passed
@pierre-guillot-gh pierre-guillot-gh deleted the claire/codeowners branch March 28, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istvan-bodo-sonarsource istvan-bodo-sonarsource istvan-bodo-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@claire-villard-sonarsource @istvan-bodo-sonarsource @pierre-guillot-gh